This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Polish sectionTitle #10901
Merged
Polish sectionTitle #10901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #10900 Addresses #8235 Addresses #10898 Addresses #10899 - Add white-space: nowrap - Replace display: inline-block with display: block - Replace Button with BrowserButton on history.js - Remove hacks on bookmarks.less and siteDetails.less by applying flex Auditors: Test Plan: 1. Open about:history 2. Open about:bookmarks 3. Make sure the headers appear on the same place
luixxiul
commented
Sep 11, 2017
| </div> | ||
| </div> | ||
| </div> | ||
| } | ||
| } | ||
|
|
||
| const styles = StyleSheet.create({ | ||
| bookmarksManager__header: { |
There was a problem hiding this comment.
It will be deprecated with a component like <SiteDetailsPageHeader actions>.
luixxiul
commented
Sep 11, 2017
| @@ -16,26 +15,10 @@ | |||
| width: 100%; | |||
| } | |||
|
|
|||
| .siteDetailsPageHeader { | |||
There was a problem hiding this comment.
This is deprecated with the flex.
luixxiul
commented
Sep 11, 2017
| .siteDetailsPageContent { | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| height: 100%; | ||
| margin: 0; |
luixxiul
commented
Sep 11, 2017
| @@ -19,8 +18,6 @@ body { | |||
| padding: 0 @aboutPageSectionPadding; | |||
|
|
|||
| .headerActions { | |||
| float: right; | |||
luixxiul
commented
Sep 11, 2017
8 tasks
luixxiul
added
the
priority/P4
luixxiul
removed
the
priority/P4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10900
Addresses #8235
Addresses #10898
Addresses #10899
Auditors:
Test Plan:
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
Tests